Support ssh signing [fixes #123] #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated tox.ini to pass SSH_AUTH_SOCK through to the test env. This assumes ssh-agent is already running.
This enables cleaning up the ssh-add operation when the test finishes.
|
If it can be of any help, I've been using this feature branch to successfully sign my commits for the past two few days without issues. Thanks for the patch @jeremy-w 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the logic in git's
sign_buffer_ssh()function in order to support signing commits with ssh keys.The test assumes an ssh-agent is running. It heavily mirrors test_gpgsign, but omits the tests for argument/config handling around whether or not to sign.
[fixes #123]