Fix missing no-change message in -ie mode #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anordal
force-pushed
the
fix-missing-nochange-msg-in-msgedit-mode
branch
2 times, most recently
from
e4660b0
to
015b93b
Compare
Using an out-argument because it is (to my knowledge) not possible to get at the value returned from a contextmanager function.
This warning is nice to see,
but only worked in `-i` and `-e` mode, not in `-ie` mode:
(warning) no changes performed
The Step.message was initialized to None instead of the old value,
causing unedited messages in message-edit mode to compare unequal.
This commit removes the optionality and thereby the possibility
for the problem.
It can also be solved by interpreting None as the old value
or resetting the new value to None if it is indifferent.
anordal
force-pushed
the
fix-missing-nochange-msg-in-msgedit-mode
branch
from
015b93b
to
baf5d75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This warning is nice to see, but only worked in
-iand-emode, not in-iemode:The Step.message was initialized to None instead of the old value,
causing unedited messages in message-edit mode to compare unequal.
This commit removes the optionality and thereby the possibility for the problem.
It can also be solved by interpreting None as the old value
or resetting the new value to None if it is indifferent.