Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commit signing does not support SSH signatures #123

Open
grncdr opened this issue Feb 23, 2022 · 3 comments · May be fixed by #136
Open

Commit signing does not support SSH signatures #123

grncdr opened this issue Feb 23, 2022 · 3 comments · May be fixed by #136

Comments

@grncdr
Copy link

grncdr commented Feb 23, 2022

It seems that git-revise breaks when git is configured to sign commits with gpg.format = ssh. The comments in #46 indicate that commit signing here is implemented independently of that in Git itself, any chance that support for ssh signing could be added?

I'd be happy to take a crack at implementing it. I know a bit about Gits implementation (it's gotten more complex in recent versions) but I'm not familiar with the git-revise codebase at all so any pointers there would be appreciated.
@grncdr grncdr changed the title Commit signing does not support SSH signature Commit signing does not support SSH signatures Feb 23, 2022
@krobelus
Copy link
Contributor

Sure A good strategy is to translate what Git does to Python. Both implementations have sign_buffer(), but ours does not respect gpg.format.

@9999years
Copy link

I'm a little perplexed that git-revise doesn't just use the built-in git commit signing process. Is there a reason it can't?

@krobelus
Copy link
Contributor

One problem is that Git does not expose a shared library with sign_buffer().
We don't want to shell out to git commit because that does more than we want to, also it requires creating a Git worktree which can be relatively slow.

Maybe there is a third party git library that we could use for signing.

jeremy-w added a commit to jeremy-w/git-revise that referenced this issue Apr 16, 2024
@jeremy-w
odb.Repository.sign_buffer: Support gpg.format = ssh [fixes mystor#123]
bdcb254
jeremy-w added a commit to jeremy-w/git-revise that referenced this issue Apr 16, 2024
@jeremy-w
odb.Repository.sign_buffer: Support gpg.format = ssh [fixes mystor#123]
fb41224
@jeremy-w jeremy-w linked a pull request Apr 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support ssh signing [fixes #123] jeremy-w/git-revise
3 participants
@grncdr @krobelus @9999years