Fix: follow tc39/ecma262#910 (refs eslint/eslint#10861)

mysticatea · Oct 5, 2018 · 0dc0b65 · 0dc0b65
1 parent 813344e
commit 0dc0b65
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 0 deletions.
diff --git a/src/validator.ts b/src/validator.ts
@@ -902,6 +902,9 @@ export class RegExpValidator {
             if (cp === RightParenthesis) {
                 this.raise("Unmatched ')'")
             }
+            if (cp === ReverseSolidus) {
+                this.raise("\\ at end of pattern")
+            }
             if (cp === RightSquareBracket || cp === RightCurlyBracket) {
                 this.raise("Lone quantifier brackets")
             }
@@ -1176,6 +1179,7 @@ export class RegExpValidator {
         return (
             this.eatDot() ||
             this.eatReverseSolidusAtomEscape() ||
+            this.eatReverseSolidusFollowedByC() ||
             this.eatCharacterClass() ||
             this.eatUncapturingGroup() ||
             this.eatCapturingGroup() ||
@@ -1184,6 +1188,20 @@ export class RegExpValidator {
         )
     }
 
+    // \ [lookahead = c]
+    private eatReverseSolidusFollowedByC(): boolean {
+        if (
+            this.currentCodePoint === ReverseSolidus &&
+            this.nextCodePoint === LatinSmallLetterC
+        ) {
+            this._lastIntValue = this.currentCodePoint
+            this.advance()
+            this.onCharacter(this.index - 1, this.index, ReverseSolidus)
+            return true
+        }
+        return false
+    }
+
     // https://www.ecma-international.org/ecma-262/8.0/#prod-strict-InvalidBracedQuantifier
     private eatInvalidBracedQuantifier(): boolean {
         if (this.eatBracedQuantifier(true)) {
@@ -1222,6 +1240,7 @@ export class RegExpValidator {
             cp !== -1 &&
             cp !== CircumflexAccent &&
             cp !== DollarSign &&
+            cp !== ReverseSolidus &&
             cp !== FullStop &&
             cp !== Asterisk &&
             cp !== PlusSign &&
@@ -1457,6 +1476,7 @@ export class RegExpValidator {
     }
 
     // https://www.ecma-international.org/ecma-262/8.0/#prod-RegExpUnicodeEscapeSequence
+    //eslint-disable-next-line complexity
     private eatRegExpUnicodeEscapeSequence(): boolean {
         const start = this.index
 

diff --git a/test/parser.ts b/test/parser.ts
@@ -74,3 +74,14 @@ describe("parseRegExpLiteral function:", () => {
         assert.deepStrictEqual(actual, expected)
     })
 })
+
+describe("RegExpParser:", () => {
+    describe("parsePattern function", () => {
+        it("should throw syntax error on '\\'.", () => {
+            assert.throws(
+                () => new RegExpParser().parsePattern("\\"),
+                /\\ at end of pattern/,
+            )
+        })
+    })
+})