Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UNKNOWN_CODE_PLEASE_REPORT to identify uknown code #2516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

glensc
Copy link

@glensc glensc commented Aug 9, 2021

Changes UNKNOWN_CODE_PLEASE_REPORT to include packet.errno in it.

This makes it easier to identify what the code is even if the code is not yet supported:

(node:1) UnhandledPromiseRejectionWarning: Error: UNKNOWN_CODE_PLEASE_REPORT: Query execution was interrupted, query_timeout exceeded

@glensc glensc force-pushed the patch-1 branch 2 times, most recently from 7c9f847 to c8970f4 Compare September 15, 2021 09:02
Copy link
Member

@dougwilson dougwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not change the code property to be dymanic like this. The code property should work like it does in Node.js core as a single value without spaces. If you are trying to add the errno to the message, then just add it to the mesaage string.

@glensc
Copy link
Author

glensc commented Sep 15, 2021

@dougwilson 19aa86d

Changes UNKNOWN_CODE_PLEASE_REPORT to include packet.errno in it.

This makes it easier to identify what the code is even if the code is not yet supported:

```
(node:1) UnhandledPromiseRejectionWarning: Error: UNKNOWN_CODE_PLEASE_REPORT: Query execution was interrupted, query_timeout exceeded
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants