Use GitHub actions to run RuboCop linter #5820
Conversation
gbp
force-pushed
the
drop-houndci
branch
2 times, most recently
from
522d406
to
22d059f
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
rubocop_test.rb
Outdated
| # BAD: fail only signal exception | ||
| begin | ||
| fail | ||
| rescue StandardError |
There was a problem hiding this comment.
Lint/SuppressedException: Do not suppress exceptions.
There was a problem hiding this comment.
Hadn't intended this to be checked - not picked up locally when running bundle exec rubocop -D rubocop_test.rb
There was a problem hiding this comment.
This wasn't raised in the GitHub action runner, I think because Hound is using Rubocop 0.80.1, instead of 0.81.0 - there was this change rubocop/rubocop#7805
Doesn't explain the other consistencies tho.
rubocop_test.rb
Outdated
| end | ||
| # BAD: fail only signal exception | ||
| begin | ||
| fail |
There was a problem hiding this comment.
Style/SignalException: Always use raise to signal exceptions.
rubocop_test.rb
Outdated
| # GOOD: raise only signal exception | ||
| begin | ||
| raise | ||
| rescue StandardError |
There was a problem hiding this comment.
Lint/SuppressedException: Do not suppress exceptions.
There was a problem hiding this comment.
Hadn't intended this to be checked - not picked up locally when running bundle exec rubocop -D rubocop_test.rb
rubocop_test.rb
Outdated
| # GOOD: lines over 80 characters | ||
| _short_line = 'This line is under 80 characters.' | ||
| # BAD: lines over 80 characters | ||
| _long_line = 'This line is going to really long and be over the 80 characters.' |
There was a problem hiding this comment.
Layout/LineLength: Line is too long. [81/80]
rubocop_test.rb
Outdated
| # BAD: old style hash syntax | ||
| _bad1_hash = { :bar => 'bar' } | ||
| # BAD: mixed keys syntax | ||
| _bad2_hash = { foo: 'foo', :bar => 'bar' } |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
rubocop_test.rb
Outdated
| # GOOD: new style hash syntax, with no mixed keys | ||
| _good_hash = { foo: 'foo' } | ||
| # BAD: old style hash syntax | ||
| _bad1_hash = { :bar => 'bar' } |
There was a problem hiding this comment.
Style/HashSyntax: Use the new Ruby 1.9 hash syntax.
rubocop_test.rb
Outdated
| # | ||
| class RubocopTest | ||
| # GOOD: trailing dots | ||
| 'Hello world'. |
There was a problem hiding this comment.
Layout/DotPosition: Place the . on the next line, together with the method name.
There was a problem hiding this comment.
This is using the wrong enforced style: https://github.com/mysociety/alaveteli/blob/develop/.ruby-style.yml#L100-L102
rubocop_test.rb
Outdated
| @@ -0,0 +1,35 @@ | |||
| # This class is a test of Rubocop linting | |||
There was a problem hiding this comment.
Style/FrozenStringLiteralComment: Missing frozen string literal comment.
There was a problem hiding this comment.
This shouldn't be running: https://github.com/mysociety/alaveteli/blob/develop/.ruby-style.yml#L1093-L1094
|
So instead of fixing HoundCI I'm purposing switching to a GitHub Action workflow. It will allow us more flexibilities with regard to gem version and RuboCop extensions. Even better it doesn't pollute the PR with comments. @garethrees what are your thoughts? If you approve I'll drop the hound config and remove the RuboCop test file from this PR. |
There seems to be ongoing issues with HoundCI, and the lately it seems to be ignoring out RuboCop config completely.
mysociety-pusher
force-pushed
the
drop-houndci
branch
from
22d059f
to
e5f1c08
Compare
gbp
changed the title
|
Discussed on standup, we're happy for this to be merged as is. |
There seems to be ongoing issues with HoundCI, and the lately it seems
to be ignoring out RuboCop config completely.