Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy_mypyc-wheels: rewrite using Github Actions and cibuildwheel #11

Merged
merged 12 commits into from Jan 7, 2021

Conversation

hauntsaninja
Copy link
Collaborator

@hauntsaninja hauntsaninja commented Oct 9, 2020

There are more details over at python/mypy#9536
These changes go together with python/mypy#9570

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Oct 13, 2020

List of improvements we can make once this is merged:

  • Once my MANIFEST.in change is merged, see if we can remove the copying over of pytest files hack (which I inherited from https://github.com/python/mypy/blob/master/misc/test_installed_version.sh)
  • That will also allow us to run check-manifest as a step here
  • Add mypyc requirements to pyproject.toml so isolated builds are possible
  • Run some tests against sdist and Python wheel
  • Factor some of the repetition in this file

Copy link
Contributor

@msullivan msullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems pretty reasonable to me and we should move forward with it. We should coordinate merging it so I can bother you about any "fine-tuning" that needs to be done.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Oct 18, 2020

Thanks, sounds good! I'll be around any weekend in the next month to fix issues that may arise.
Might be wise to wait until we're sure we don't need to make any more 0.79* releases (e.g., do we need a new release for python/mypy#9584?)

@mr-c
Copy link

mr-c commented Oct 18, 2020

@hauntsaninja a 0.791 release to fix building mypyc from the sdist would be appreciated for Debian and other packaging systems

@hauntsaninja
Copy link
Collaborator Author

I don't have the ability to make that happen, but I posted on your behalf at python/mypy#9290 :-)

@mr-c
Copy link

mr-c commented Oct 18, 2020

@hauntsaninja thanks! Debian patched around the issue (and cherry picked the Python 3.9 patches) but I'm sure other distributions and packaging systems would appreciate it.

@JukkaL
Copy link
Collaborator

JukkaL commented Oct 23, 2020

I'm going to make the 0.791 release soon.

@hauntsaninja
Copy link
Collaborator Author

hauntsaninja commented Nov 26, 2020

@msullivan Shall we go ahead and merge? I'll be able to fix any issues that come up this weekend / it might make sense to give me write access to this repo

(Also not fully sure what needs to be done to tell AppVeyor it's over between us)

@JukkaL
Copy link
Collaborator

JukkaL commented Jan 6, 2021

@hauntsaninja I gave you access to this repository. Please let me know if there something else that you need to allow you to move this PR forward. This will be great to have, and I now have more time to help with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants