Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move to ubuntu 18.04 #38

Closed
wants to merge 1 commit into from
Closed

Conversation

aslafy-z
Copy link
Contributor

@aslafy-z aslafy-z commented Jun 30, 2020

@myoung34
Copy link
Owner

myoung34 commented Jun 30, 2020

Unless I'm misunderstanding something, Bionic is already supported and deployed:

Base dockerfile -> artifact

Final dockerfile (not pinned to a GH action tag) -> artifact

Final dockerfile (pinned to a GH action tag) -> artifact

to use this you just wouldnt pin your runner to latest (which is eoan) but to ubuntu-bionic (essentially latest but on bionic and not eoan):

docker run -d --restart always --name github-runner \
  -e RUNNER_NAME_PREFIX="myrunner" \
  -e ACCESS_TOKEN="footoken" \
  -e RUNNER_WORKDIR="/tmp/github-runner-your-repo" \
  -e ORG_RUNNER="true" \
  -e ORG_NAME="octokode" \
  -e LABELS="my-label,other-label" \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v /tmp/github-runner-your-repo:/tmp/github-runner-your-repo \
  myoung34/github-runner:ubuntu-bionic

or a specific tag for bionic:

docker run -d --restart always --name github-runner \
  -e RUNNER_NAME_PREFIX="myrunner" \
  -e ACCESS_TOKEN="footoken" \
  -e RUNNER_WORKDIR="/tmp/github-runner-your-repo" \
  -e ORG_RUNNER="true" \
  -e ORG_NAME="octokode" \
  -e LABELS="my-label,other-label" \
  -v /var/run/docker.sock:/var/run/docker.sock \
  -v /tmp/github-runner-your-repo:/tmp/github-runner-your-repo \
  myoung34/github-runner:2.267.0-ubuntu-bionic

@aslafy-z
Copy link
Contributor Author

Oh great! I missed that, sorry. It might be good to add a mention in the README about these tags. Thanks for your work!

@myoung34
Copy link
Owner

Ill add a TODO and add that to the README, you're right that its easy to miss.

@myoung34 myoung34 closed this Jun 30, 2020
@aslafy-z aslafy-z deleted the patch-2 branch June 30, 2020 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants