Redis cluster support and timeout control on single query result #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bit much for a single issue, don't you think? I think it is best if you open separates issues. Some of them don't seem related. For example what has Kyro to do with a redis cluster? Why go back to Junit 4 just because your commit needs it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch will add Redis cluster support and timeout control on single query result. The timeout timestamp is added to the tail of the serialized bytes to tell if it is expired. When using this in a distributed environment, it is recommended to remove the flushInterval property.
The JUnit Jupiter test cases always failed in my local environment when running "shouldDemonstrateCopiesAreEqual", so I replaced it with standard JUnit.