Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a reace condition caused by one thread calls getMapper method while other threads calling addMapper #2901

Merged
merged 1 commit into from Jul 11, 2023

Conversation

uniquewings
Copy link
Contributor

@uniquewings uniquewings commented Jul 10, 2023

fix the issue 2890: #2890

…le other threads calling addMapper

fix the issue 2890: mybatis#2890
@hazendaz hazendaz self-assigned this Jul 11, 2023
@coveralls
Copy link

Coverage Status

coverage: 87.545%. remained the same when pulling 3b27083 on uniquewings:knownmapper_race into 338f54b on mybatis:master.

@hazendaz
Copy link
Member

Hi @uniquewings , any chance you can test this in your setup and see if it resolves? The other change did a bit more which seemed to be needed, I'm not sure if same is needed here or if this change alone will fix it. I don't see any problem in merging this otherwise though. We do publish to sonatype snapshots in case that helps to pull from there for testing purposes rather than build your own.

@hazendaz hazendaz merged commit bc5aa5f into mybatis:master Jul 11, 2023
14 checks passed
nieqiurong added a commit to baomidou/mybatis-plus that referenced this pull request Oct 10, 2023
@kazuki43zoo kazuki43zoo changed the title Fix a reace condition caused by one thread calls getMapper method whi… Fix a reace condition caused by one thread calls getMapper method while other threads calling addMapper Oct 29, 2023
@kazuki43zoo kazuki43zoo added the enhancement Improve a feature or add a new feature label Oct 29, 2023
@kazuki43zoo kazuki43zoo added this to the 3.5.14 milestone Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve a feature or add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants