Prevent thread from being blocked by JDK-8 ConcurrentHashMap#computeIfAbsent() #2223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fAbsent() This is a workaround for JDK-8161372 mybatis#1929 https://groups.google.com/g/mybatis-user/c/iBTN98c0dP4/m/H6IJS-LzAQAJ We should drop this workaround once we drop Java 8 support or the fix is backported.
harawata
added
the
bug on dependency library
drtrang
reviewed
May 13, 2021
| if (value != null) { | ||
| return value; | ||
| } | ||
| return map.computeIfAbsent(key, mappingFunction::apply); |
There was a problem hiding this comment.
ComputeIfAbsent blocks when multiple threads obtain the same key. I think it's to improve performance. https://bugs.openjdk.java.net/browse/JDK-8161372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for JDK-8161372.
Related to ...
We should drop this workaround once we drop Java 8 support (or the fix is backported).