Avoid invoking equals/hashCode when assigning generated keys #1728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When detecting single parameter case, it now checks parameter name instead of equality of the parameter objects. This should fix mybatisgh-1719. A caveat : when there is only one parameter and its name is 'param2' (for whatever reason), `keyProperty` must include the parameter name i.e. `keyProperty="param2.xx"`.
harawata
force-pushed
the
jdbc3keygenerator-npe
branch
from
51e0de7
to
3496397
Compare
pulllock
pushed a commit
to pulllock/mybatis-3
that referenced
this pull request
Oct 19, 2023
Avoid invoking equals/hashCode when assigning generated keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When detecting single parameter case, it now checks parameter name instead of equality of the parameter objects.
This should fix gh-1719.
A caveat : when there is only one parameter and its name is 'param2' (for whatever reason),
keyPropertymust include the parameter name i.e.keyProperty="param2.xx".