Merge pull request #1790 from mustaphazorgati/master

made closeConnection in the Runner classes deprecated
mybatis · Dec 28, 2019 · d2cb615 · d2cb615
2 parents f232291 + 303fd65
commit d2cb615
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java b/src/main/java/org/apache/ibatis/jdbc/ScriptRunner.java
@@ -151,6 +151,10 @@ private void executeLineByLine(Reader reader) {
     }
   }
 
+  /**
+   * @deprecated Since 3.5.4, this method is deprecated. Please close the {@link Connection} outside of this class.
+   */
+  @Deprecated
   public void closeConnection() {
     try {
       connection.close();

diff --git a/src/main/java/org/apache/ibatis/jdbc/SqlRunner.java b/src/main/java/org/apache/ibatis/jdbc/SqlRunner.java
@@ -191,6 +191,10 @@ public void run(String sql) throws SQLException {
     }
   }
 
+  /**
+   * @deprecated Since 3.5.4, this method is deprecated. Please close the {@link Connection} outside of this class.
+   */
+  @Deprecated
   public void closeConnection() {
     try {
       connection.close();