Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posting Previews #533

Draft
wants to merge 15 commits into
base: develop
Choose a base branch
from
Draft

Conversation

lukasbischof
Copy link
Member

No description provided.

@lukasbischof
Copy link
Member Author

lukasbischof commented Oct 31, 2022

Stuff which probably should be improved:

  1. U just deleted the courses and available times?
  2. Layout jumps when one opens the application form
  3. Close button no margin on desktop
  4. The first attributes block has no consistent top margin
  5. Me still don't really like the header with small logo, me would still change on modal, details and list view to first list the title and then subsequently the company name in gray
  6. header doesn't align with content currently
  7. We probably should include a loading indicator since currently u just see two buttons and no content when internet slow
  8. I'd make the modal completely opaque on mobile, the translucency effect doesn't really help I'd say since it's mostly just gray anyways
  9. Somewhen there's a visible scroll bar at the bottom attributed list

@TheFehr
Copy link
Member

TheFehr commented Oct 31, 2022

Stuff which probably should be improved:

1. U just deleted the courses and available times?

2. Layout jumps when one opens the application form

3. Close button no margin on desktop

4. The first attributes block has no consistent top margin

5. Me still don't really like the header with small logo, me would still change on modal, details and list view to first list the title and then subsequently the company name in gray

6. header doesn't align with content currently

7. We probably should include a loading indicator since currently u just see two buttons and no content when internet slow

8. I'd make the modal completely opaque on mobile, the translucency effect doesn't really help I'd say since it's mostly just gray anyways

Open tasks:

  • Add courses and available times (probably above map)
  • fix layout jump on desktop inquiry form open
  • fix first attributes block consistent top margin
  • change title order in all 3 places
  • fix header to content alignment
  • add loading/failure indicator
  • fix desktop buttons being side by side sometimes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants