Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

format: exclude body on CaseClause len check #219

Merged
merged 1 commit into from Apr 19, 2022
Merged

format: exclude body on CaseClause len check #219

merged 1 commit into from Apr 19, 2022

Conversation

Oiyoo
Copy link
Collaborator

@Oiyoo Oiyoo commented Apr 3, 2022

fixes #217

@Oiyoo Oiyoo requested a review from mvdan April 3, 2022 15:58
mvdan
mvdan approved these changes Apr 4, 2022
View reviewed changes
Copy link
Owner

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This is definitely what I meant to do when I wrote (or reviewed?) the code.

Don't merge just yet, though, because I think the issue author argues the gofumpt rule is a bad idea.

@mvdan
Copy link
Owner

mvdan commented Apr 19, 2022

Followed up with OP, but in any case, this is a correct fix :) Thanks again!

@mvdan mvdan merged commit b5619f8 into mvdan:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent formatting of switch cases with and without content
2 participants
@Oiyoo @mvdan