Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug that removes decimal separator in decimal values #127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

obrunodelgado
Copy link

@obrunodelgado obrunodelgado commented May 1, 2023

This Pull Request resolves the bug that removed the "." (decimal separator) character from decimal values, causing issues in the representation of fractional numbers. Due to this bug, values like 0.14 were incorrectly transformed into 014, leading to potential errors in calculations and numerical data visualization.

Evidence of the bug before the execution of fmt_dec:

Screenshot from 2023-05-01 12-08-03

After the execution of fmt_dec:
Screenshot from 2023-05-01 12-08-13

Changes made:

  1. Identification and correction of the code snippet responsible for the bug, ensuring that the decimal separator is preserved when handling decimal values.
  2. Updated test_fmt_dec unit tests for this fix.

I believe this fix will bring greater reliability and accuracy to the project, preventing errors related to the handling of decimal values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant