Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove old tests files which have been merged #147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

musikid
Copy link
Owner

@musikid musikid commented Mar 26, 2024

No description provided.

@musikid musikid requested a review from asomers March 26, 2024 12:39
Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In reviewing my own past PRs, I noticed that I actually left out a few things from the granular tests. I have a PR in progress to fix that. So please don't delete them yet. Did you review the other changes, too?

@@ -75,6 +75,7 @@ fn get_flags(ctx: &TestContext) -> (FileFlag, FileFlag, FileFlag) {

crate::test_case! {
/// chflags(2) set the flags provided for the file.
// chflags/00.t
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think it's still useful to leave these comments in place.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, that's why I added those which were missing.

@musikid
Copy link
Owner Author

musikid commented Apr 19, 2024

In reviewing my own past PRs, I noticed that I actually left out a few things from the granular tests. I have a PR in progress to fix that. So please don't delete them yet. Did you review the other changes, too?

If you're talking about your tests other than the granular ones, then yes I did a quick review of those.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants