Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting of results #145

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

asomers
Copy link
Collaborator

@asomers asomers commented Feb 25, 2024

  • Align output columns, assuming 80-column terminal
  • Use "ok/FAILED" instead of "success/FAILURE", as the standard test harness does.
  • Remove the newline after a skipped test
  • Strip "pjdfstest::tests::" from all test case names.
  • Move a failed test's failure message to a new line.
  • Indent a skipped test's skip reasons.

Fixes #140

* Align output columns, assuming 80-column terminal
* Use "ok/FAILED" instead of "success/FAILURE", as the standard test
  harness does.
* Remove the newline after a skipped test
* Strip "pjdfstest::tests::" from all test case names.
* Move a failed test's failure message to a new line.
* Indent a skipped test's skip reasons.

Fixes #140
@asomers asomers requested a review from musikid February 26, 2024 00:44
rust/src/test.rs Outdated Show resolved Hide resolved
Copy link
Owner

@musikid musikid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a comment about the traits.

@asomers asomers merged commit ca2415a into musikid:master Mar 5, 2024
3 checks passed
@asomers asomers deleted the better-formatting branch March 5, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better formatted output
2 participants