Fix all warnings, and deny them in CI #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* useless_conversion * needless_borrow * needless_borrows_for_generic_args * unnecessary_cast * dead_code
And also clippy::borrow_interior_mutable_const . Even though we never intended to mutate those objects, it was technically still a problem to make them const, because it results in the compiler copying them anywhere they are needed. So better to make them static. While I'm here, replace the once_cell crate with the new std::sync::OnceLock structure, to reduce external dependencies.
This change removes two unused macros: support_file_flags and assert_mtime_unchanged. They can be resurrected from git history if we ever need them.
asomers
force-pushed
the
deny-warnings
branch
from
293ef6e
to
9ef0dd5
Compare
musikid
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes two unused macros: support_file_flags and assert_mtime_unchanged. They can be resurrected from git history if we ever need them.