Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(rename): add EACCES sticky tests #134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat(rename): add EACCES sticky tests #134

wants to merge 3 commits into from

Conversation

musikid
Copy link
Owner

@musikid musikid commented Sep 16, 2023

No description provided.

@musikid musikid marked this pull request as ready for review March 5, 2024 18:48
@musikid musikid requested a review from asomers March 5, 2024 18:48
@musikid
Copy link
Owner Author

musikid commented Mar 5, 2024 •
edited

@asomers I'm thinking that the macro function I wrote for this test is maybe too much generic and makes it difficult to understand, what do you think of it?

@musikid musikid changed the title feat(rename): add sticky tests feat(rename): add EACCES sticky tests Mar 5, 2024
@asomers
Copy link
Collaborator

asomers commented Mar 9, 2024

What I worry about isn't the macro. I worry that assert_sticky_rename is too big. Can you break it up into separate test cases?

@musikid
Copy link
Owner Author

musikid commented Mar 9, 2024

What I worry about isn't the macro. I worry that assert_sticky_rename is too big. Can you break it up into separate test cases?

Yes, I was talking about the function I don't know why I said macro.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asomers asomers Awaiting requested review from asomers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@musikid @asomers