New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto-loader: use method descriptor types to define server handlers #2

Merged

murgatroid99 merged 2 commits into murgatroid99:proto-loader_type_generator from badsyntax:proto-loader_type_generator

Sep 24, 2020

badsyntax commented Sep 24, 2020

This change will allow for better compatibility with the grpc package.

This change should not be merged until this PR is merged: grpc#1587

See: grpc#1474 (comment)


          proto-loader: use method descriptor types to define server handlers

acf403b

badsyntax mentioned this pull request

proto-loader: Add TypeScript generator grpc/grpc-node#1474

Merged

Owner

murgatroid99 commented Sep 24, 2020

Can you regenerate the golden output files to keep them consistent with the generator changes? (npm run compile && npm run generate-golden)


          Regenerate golden types

829333c

murgatroid99 merged commit 4f52097 into murgatroid99:proto-loader_type_generator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment