add codecs for ed25519 public keys and signatures with different hash types #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent underlying hash functions
|
@Stebalien is this all good? |
|
🤔 |
cyphar
reviewed
Feb 23, 2020
| @@ -70,6 +70,7 @@ ipfs-ns, namespace, 0xe3, IPFS path | |||
| swarm-ns, namespace, 0xe4, Swarm path | |||
| ipns-ns, namespace, 0xe5, IPNS path | |||
| ed25519-pub, key, 0xed, Ed25519 public key | |||
| ed25519-sig, signature, 0xef, Ed25519 signature | |||
There was a problem hiding this comment.
Why not make ed25519-{pub,sig} mean using Ed25519-SHA2 (since that's what effectively all Ed25519 users use), and then add only ed25519-{pub,sig}-sha3? It seems a bit odd to me to have two codec entries which are ambiguous.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #139