Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replace blake2b implementation by golang.org/x/crypto #157

Merged
merged 3 commits into from Jun 22, 2022
Merged

chore: replace blake2b implementation by golang.org/x/crypto #157

merged 3 commits into from Jun 22, 2022

Commits on Jun 22, 2022

  1. test: add blake2b

    @Jorropo
    Jorropo committed Jun 22, 2022
    Copy the full SHA
    584ca60 View commit details
    Browse the repository at this point in the history

  2. chore: replace blake2b implementation by golang.org/x/crypto 

    In 2016-12-13 d8e61c69ab46ca38328da2f4995abaf93b252290 golang.org/x/crypto gained a blake2b AVX implementation.

There is also an AVX2 one.

It is faster than what we are using right now.

This commit allows for faster code and remove a dependency.

For future improvements (like NEON) /x/crypto seems more maintained (it isn't an archived repo).

benchmark              old ns/op     new ns/op     delta
BenchmarkSum128-12     252           140           -44.35%
BenchmarkSum1K-12      1221          986           -19.24%

benchmark              old MB/s     new MB/s     speedup
BenchmarkSum128-12     507.37       911.98       1.80x
BenchmarkSum1K-12      838.70       1038.43      1.24x
    @Jorropo
    Jorropo committed Jun 22, 2022
    Copy the full SHA
    bc367d5 View commit details
    Browse the repository at this point in the history

  3. chore: release v0.2.0

    @Jorropo
    Jorropo committed Jun 22, 2022
    Copy the full SHA
    6a7a019 View commit details
    Browse the repository at this point in the history