Skip to content

Commit

Permalink
Merge pull request #155 from marten-seemann/guard-against-nil-addrs
Browse files Browse the repository at this point in the history
guard against nil {Local,Remote}Addr() return values
  • Loading branch information
marten-seemann committed Jun 24, 2021
2 parents 2f4fae4 + 1a8d3e4 commit 7cb054e
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions net/net.go
Expand Up @@ -248,16 +248,16 @@ func (l *maListener) Accept() (Conn, error) {
var raddr ma.Multiaddr
// This block protects us in transports (i.e. unix sockets) that don't have
// remote addresses for inbound connections.
if nconn.RemoteAddr().String() != "" {
raddr, err = FromNetAddr(nconn.RemoteAddr())
if addr := nconn.RemoteAddr(); addr != nil && addr.String() != "" {
raddr, err = FromNetAddr(addr)
if err != nil {
return nil, fmt.Errorf("failed to convert conn.RemoteAddr: %s", err)
}
}

var laddr ma.Multiaddr
if nconn.LocalAddr().String() != "" {
laddr, err = FromNetAddr(nconn.LocalAddr())
if addr := nconn.LocalAddr(); addr != nil && addr.String() != "" {
laddr, err = FromNetAddr(addr)
if err != nil {
return nil, fmt.Errorf("failed to convert conn.LocalAddr: %s", err)
}
Expand Down

0 comments on commit 7cb054e

Please sign in to comment.