Added Python 3.10 #422
Merged
Added Python 3.10 #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
commented
Aug 13, 2021
| @@ -162,7 +165,7 @@ function pyinst_fname_for_version { | |||
| # creates intel only wheels by default. When PLAT=universal2 | |||
| # we set the env variable _PYTHON_HOST_PLATFORM to change this | |||
| # default. | |||
| if [ "$(uname -m)" == "arm64" ]; then | |||
| if [ "$(uname -m)" == "arm64" ] || [ $(lex_ver $py_version) -ge $(lex_ver 3.10.0) ]; then | |||
There was a problem hiding this comment.
https://www.python.org/ftp/python/3.10.0/ has python-3.10.0rc1-macos11.pkg, but no macosx10.9.pkg for rc1
|
Hmm - can we compile everything on an 11 image, to work correctly on a
10.9 machine? Or do we need the 10.9 installer for something?
|
|
Over in pillow-wheels, after building a wheel, we install the wheel and run our tests with it. I ran a test with these changes for Python 3.10 on a non-macOS 11 machine, and it passed - https://github.com/radarhere/pillow-wheels/runs/3330568117#step:4:6278 |
matthew-brett
approved these changes
Aug 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Python 3.10 for #421