-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Electron to version 30 #6253
Conversation
0c6f426
to
fcb115d
Compare
fcb115d
to
03f59e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion (waiting on @dlon)
test/test-manager/src/vm/qemu.rs
line 26 at r2 (raw file):
const STDERR_LOG_LEVEL: log::Level = log::Level::Error; const STDOUT_LOG_LEVEL: log::Level = log::Level::Debug; const OBTAIN_IP_TIMEOUT: Duration = Duration::from_secs(180);
Is this related to the Electron upgrade?
4e74c8a
to
03f59e4
Compare
48a8bf9
to
236c0a8
Compare
03f59e4
to
6f1d1fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 4 files reviewed, all discussions resolved (waiting on @raksooo)
test/test-manager/src/vm/qemu.rs
line 26 at r2 (raw file):
Previously, raksooo (Oskar Nyberg) wrote…
Is this related to the Electron upgrade?
Only very indirectly. I've reverted it and fixed it in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
Here are the changelogs for versions 29 and 30:
https://github.com/electron/electron/releases/tag/v30.0.0
https://github.com/electron/electron/releases/tag/v29.0.0
Fix DES-867.
This change is