Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include apisocks5 in application bundle #6234

Merged
merged 3 commits into from
May 28, 2024

Conversation

hulthe
Copy link
Contributor

@hulthe hulthe commented May 8, 2024


This change is Reviewable

Copy link

linear bot commented May 8, 2024

@hulthe
Copy link
Contributor Author

hulthe commented May 13, 2024

@raksooo are there any more build scripts I need to fix?

@hulthe
Copy link
Contributor Author

hulthe commented May 13, 2024

note: the binaries submodule on this branch is pointing to a temporary commit I made for testing. Gonna update it once the binaries repo changes have been properly merged and built.

@hulthe hulthe force-pushed the update-installer-build-to-include-apisocks5-des-916 branch from 16acbb5 to 57b722f Compare May 24, 2024 13:32
@hulthe
Copy link
Contributor Author

hulthe commented May 24, 2024

submodule is now updated

@hulthe hulthe marked this pull request as ready for review May 24, 2024 13:52
@hulthe hulthe force-pushed the update-installer-build-to-include-apisocks5-des-916 branch from 57b722f to 3157bc2 Compare May 24, 2024 13:54
@hulthe hulthe requested a review from raksooo May 24, 2024 14:44
@hulthe hulthe self-assigned this May 24, 2024
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the update-installer-build-to-include-apisocks5-des-916 branch from 0632bc5 to ffd820e Compare May 28, 2024 07:10
@raksooo raksooo merged commit 431d51c into main May 28, 2024
19 of 20 checks passed
@raksooo raksooo deleted the update-installer-build-to-include-apisocks5-des-916 branch May 28, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants