Remove atty dependency #4936
Merged
Remove atty dependency #4936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
force-pushed
the
remove-atty-dependency
branch
from
cd0a4e4
to
38ea3ce
Compare
MarkusPettersson98
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
faern
force-pushed
the
remove-atty-dependency
branch
from
38ea3ce
to
0bbe1ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have long ignored
RUSTSEC-2021-0145in ourcargo-audit.ymlaction. And even if our app is not really affected by this vulnerability at all, it has been a bit irritating. I have been somewhat on the hunt to get rid ofattyfor a long while. Opening issues on some of our dependencies that in turn depend onatty. And finally we have reached the point where the last dependency using it has released an upgraded version, switching tois-terminal.I now ban
attyfrom our dependency tree completely viadeny.toml, so we don't accidentally add it again.This change is