Fix time zone being ignored on Android #4809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DES-235 The time zone is ignored on Android
We use Slack discussion: https://mullvad.slack.com/archives/C33N9MLQ7/p1686144914485789 |
MarkusPettersson98
changed the title
chrono to 0.4.26
MarkusPettersson98
requested review from
albin-mullvad,
faern,
pinkisemils and
Pururun
and removed request for
albin-mullvad
Pururun
approved these changes
Jun 21, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
MarkusPettersson98
force-pushed
the
the-time-zone-is-ignored-on-android-des-235
branch
2 times, most recently
from
8aca744
to
32fe78d
Compare
pinkisemils
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
Reviewed 6 of 6 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:
MarkusPettersson98
force-pushed
the
the-time-zone-is-ignored-on-android-des-235
branch
from
32fe78d
to
8d90bb5
Compare
There was a problem hiding this comment.
Feel free to do so 😊
Reviewable status:
MarkusPettersson98
force-pushed
the
the-time-zone-is-ignored-on-android-des-235
branch
from
8d90bb5
to
f7d84a7
Compare
Fix time zone being ignored on Android, incorrectly outputting UTC timestamps. This more recent version of `chrono` extracts timezone info from a tzdata file on Android. This issue is recognized in `chrono`'s issue tracker: chronotope/chrono#922
Since `chrono 0.4.23`, the use of `chrono::NaiveDateTime::from_timestamp` is deprecated in favor of `chrono::NaiveDateTime::from_timestamp_opt`, which returns an `Option` instead of panicking if number of seconds is out of range.
pinkisemils
force-pushed
the
the-time-zone-is-ignored-on-android-des-235
branch
from
f7d84a7
to
7747e2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix time zone being ignored on Android, incorrectly outputting UTC timestamps. A fix is included in
chrono >= 4.25.This issue is recognized in
chrono's issue tracker: chronotope/chrono#922, and the fix seems to be to extract timezone info from a tzdata file.This change is