Update chrono to 0.4.21 to fix Android #3863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
requested changes
Aug 25, 2022
There was a problem hiding this comment.
Reviewed 6 of 7 files at r1, all commit messages.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @pinkisemils)
mullvad-tunnel/Cargo.toml line 1 at r1 (raw file):
[package]
This file should not be here
pinkisemils
force-pushed
the
android-upgrade-chrono
branch
from
c5cfbbf
to
f5d8dde
Compare
pinkisemils
commented
Aug 25, 2022
There was a problem hiding this comment.
Reviewable status: 6 of 7 files reviewed, 1 unresolved discussion (waiting on @faern)
mullvad-tunnel/Cargo.toml line 1 at r1 (raw file):
Previously, faern (Linus Färnstrand) wrote…
This file should not be here
Done.
faern
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
pinkisemils
force-pushed
the
android-upgrade-chrono
branch
from
f5d8dde
to
16c5121
Compare
pinkisemils
force-pushed
the
android-upgrade-chrono
branch
from
16c5121
to
77471fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping chrono to a newer version to have this. Otherwise, the daemon panics upon first attempt at logging.
This change is