Bump luxon to ^3.2.0 [SECURITY] #8347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/npm-luxon-vulnerability
branch
2 times, most recently
from
f22637b
to
1b41ce6
Compare
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8347--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
oliviertassinari
added
the
security
oliviertassinari
force-pushed
the
renovate/npm-luxon-vulnerability
branch
from
f3bf315
to
af4b9ae
Compare
oliviertassinari
approved these changes
Apr 9, 2023
|
This fixes the same issue as in #8046. In moment, the CVE is GHSA-wc69-rhjr-hc9g, and the fix in moment/moment#6015. With Luxon, the CVE is GHSA-3xq5-wjfh-ppjc and the fix is moment/luxon@5ab3bf6. The trigger for me to work on it is https://mui.zendesk.com/agent/tickets/7917. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
3.2.0->3.2.1GitHub Vulnerability Alerts
CVE-2023-22467
Impact
Luxon's `DateTime.fromRFC2822() has quadratic (N^2) complexity on some specific inputs. This causes a noticeable slowdown for inputs with lengths above 10k characters. Users providing untrusted data to this method are therefore vulnerable to (Re)DoS attacks.
This is the same bug as Moment's GHSA-wc69-rhjr-hc9g
Workarounds
Limit the length of the input.
References
There is an excellent writeup of the same issue in Moment: https://github.com/moment/moment/pull/6015#issuecomment-1152961973
Details
DateTime.fromRFC2822("(".repeat(500000))takes a couple minutes to complete.Release Notes
moment/luxon
v3.2.1Compare Source
Configuration
📅 Schedule: Branch creation - "" in timezone UTC, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR has been generated by Mend Renovate. View repository job log here.