-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Remove WrapperVariantContext
from DateTimePickerTabs
#7374
[pickers] Remove WrapperVariantContext
from DateTimePickerTabs
#7374
Conversation
packages/x-date-pickers/src/DateTimePicker/DateTimePickerTabs.tsx
Outdated
Show resolved
Hide resolved
These are the results for the performance tests:
|
Couldn't we handle the styling at the Because with the current approach, |
We probably could, but that was not the intent of this PR. |
packages/x-date-pickers/src/DesktopNextDateTimePicker/DesktopNextDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/MobileDateTimePicker/MobileDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/DesktopNextDateTimePicker/DesktopNextDateTimePicker.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As soon as we have the satisfies
instead of the type casting I'm good with merging 👍
I initially did not notice the compilation error. I'm trying to understand why it might be failing to compile on our codebase, even though we have most of the latest libraries. 🤔 |
Part of #7372