Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Remove WrapperVariantContext from DateTimePickerTabs #7374

Merged

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Jan 2, 2023

Part of #7372

- extract `WrapperVariant` type from soon to be removed file `WrapperVariantContext`
@LukasTy LukasTy added the component: pickers This is the name of the generic UI component, not the React module! label Jan 2, 2023
@mui-bot
Copy link

mui-bot commented Jan 2, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7374--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 616.8 1,079.4 643.5 795.26 191.922
Sort 100k rows ms 686.1 1,296.6 869.7 950.02 199.822
Select 100k rows ms 204.3 394.9 237.3 267.22 68.426
Deselect 100k rows ms 149.6 303.9 184.6 220.76 60.482

Generated by 🚫 dangerJS against fdcf78e

@flaviendelangle
Copy link
Member

Couldn't we handle the styling at the PickersLayoutContentWrapper level ?
Set flexDirection: 'column-reverse' and set the shadow there or change the rendering order (depending on what keyboard order we want).

Because with the current approach, PickersLayout handled all the positioning and the tabs say "no no I do want to be below"

@LukasTy
Copy link
Member Author

LukasTy commented Jan 3, 2023

Couldn't we handle the styling at the PickersLayoutContentWrapper level ?

We probably could, but that was not the intent of this PR.
I'll look into this option as it could probably be even more clean solution if we could use layout and avoid the need for wrapperVariant on the tabs. 😃 👍

Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as we have the satisfies instead of the type casting I'm good with merging 👍

@LukasTy
Copy link
Member Author

LukasTy commented Jan 9, 2023

As soon as we have the satisfies instead of the type casting

I initially did not notice the compilation error. I'm trying to understand why it might be failing to compile on our codebase, even though we have most of the latest libraries. 🤔
https://stackoverflow.com/questions/74677993/typescript-react-app-is-throwing-error-when-using-the-new-satisfies-operator-w

@LukasTy LukasTy merged commit 6a9e6ea into mui:next Jan 9, 2023
@LukasTy LukasTy deleted the remove-wrapper-variant-date-time-picker-tabs branch January 9, 2023 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants