[docs] Improve Tree View selection doc #13105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Signed-off-by: Gene Arch <genepaularch@gmail.com> Co-authored-by: Rom Grk <romgrk.cc@gmail.com>
flaviendelangle
added
docs
flaviendelangle
commented
May 13, 2024
|
|
||
| {{"demo": "MultiSelectTreeView.js"}} | ||
|
|
||
| :::success |
There was a problem hiding this comment.
Unlike the data grid, I added those as success because IMHO this is more a side not than the main content here.
The main content is how to enable selection, and then we describe how to use selection but this mostly target end users which won't read to doc, so it's more to say "Hey we have good selection interactions".
flaviendelangle
commented
May 13, 2024
| @@ -54,3 +74,17 @@ Learn more about the _Controlled and uncontrolled_ pattern in the [React documen | |||
| Use the `onItemSelectionToggle` prop if you want to react to an item selection change: | |||
|
|
|||
| {{"demo": "TrackItemSelectionToggle.js"}} | |||
|
|
|||
| ## Parent / children selection relationship | |||
There was a problem hiding this comment.
Do you think it's worth adding a demo here on how to do it in user-land?
There was a problem hiding this comment.
I think it's worth it, yes 馃憣
noraleonte
approved these changes
May 14, 2024
| @@ -54,3 +74,17 @@ Learn more about the _Controlled and uncontrolled_ pattern in the [React documen | |||
| Use the `onItemSelectionToggle` prop if you want to react to an item selection change: | |||
|
|
|||
| {{"demo": "TrackItemSelectionToggle.js"}} | |||
|
|
|||
| ## Parent / children selection relationship | |||
There was a problem hiding this comment.
I think it's worth it, yes 馃憣
LukasTy
approved these changes
May 16, 2024
Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com>
flaviendelangle
force-pushed
the
selection-doc
branch
from
2a5ef15
to
0e0444b
Compare
|
Doc applied to |
arthurbalduini
pushed a commit
to arthurbalduini/mui-x
that referenced
this pull request
May 23, 2024
Signed-off-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Signed-off-by: Gene Arch <genepaularch@gmail.com> Signed-off-by: Flavien DELANGLE <flaviendelangle@gmail.com> Co-authored-by: Michel Engelen <32863416+michelengelen@users.noreply.github.com> Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com> Co-authored-by: Gene Arch <genepaularch@gmail.com> Co-authored-by: Rom Grk <romgrk.cc@gmail.com> Co-authored-by: Nora <72460825+noraleonte@users.noreply.github.com>
docs/data/tree-view/rich-tree-view/selection/ParentChildrenSelectionRelationship.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first goal was to add a single selection demo, which was really lacking.
But I ended up doing a lot more changes on this page.
I'll replicate the changes on the
SimpleTreeViewdoc once approved 馃憤I took the DataGrid doc as an inspiration, but IMHO it is not great (no link to the multi select keyboard shortcuts for instance).
SimpleTreeView