[data grid] Fix column resize not working with special character #13069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oukunan
force-pushed
the
fix-column-resize-special-characters
branch
from
059ce2f
to
23c6693
Compare
oukunan
changed the title
oukunan
changed the title
romgrk
approved these changes
May 9, 2024
zannager
added
the
component: data grid
|
Deploy preview: https://deploy-preview-13069--material-ui-x.netlify.app/ |
romgrk
reviewed
May 16, 2024
packages/x-data-grid/src/hooks/features/columnResize/useGridColumnResize.tsx
Outdated
Show resolved
Hide resolved
|
@cherniavskii I'll let you approve & merge. |
oliviertassinari
changed the title
| ); | ||
| if (headerFilterElement) { | ||
| refs.headerFilterElement = headerFilterElement as HTMLDivElement; | ||
| } | ||
|
|
||
| refs.groupHeaderElements = findGroupHeaderElementsFromField( | ||
| apiRef.current.columnHeadersContainerRef?.current!, | ||
| colDef.field, | ||
| escapedColDefField, |
There was a problem hiding this comment.
I think that the escaping should happen in findGroupHeaderElementsFromField(). Otherwise, we will reintroduce the bug the next time the function is used.
Same with findHeaderElementFromField
| // HACK: The jsdom test is failing because CSS.escape doesn't exist in that context. | ||
| // We have decided that we want to preserve the bug in jsdom | ||
| // https://github.com/mui/mui-x/pull/13069#discussion_r1603270444 | ||
| const escapedColDefField = typeof CSS === 'undefined' ? colDef.field : CSS.escape(colDef.field); |
There was a problem hiding this comment.
This is inconsistent with #2033. To normalize to have one solution for one problem.
There was a problem hiding this comment.
Agreed, use the existing escapeOperandAttributeSelector function instead of CSS.escape.
There was a problem hiding this comment.
Why not standardize on CSS.escape?
oukunan
force-pushed
the
fix-column-resize-special-characters
branch
from
c65edbb
to
0ee6603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #12954
The support of the CSS API seems common enough: https://caniuse.com/mdn-api_css_escape_static.Before: https://codesandbox.io/p/sandbox/wild-surf-ygtjk6
After: https://codesandbox.io/p/sandbox/upbeat-grass-9h7tfd