Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update validation.md #13014

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update validation.md #13014

wants to merge 1 commit into from

Conversation

machineghost
Copy link

Clarified that the component requires a null value for the validation to treat it as acceptable. As I discovered, a blank string makes the component go into the invalid validation state ... but there's currently no explanation of this behavior in the docs (that I could find).

Clarified that the component requires a `null` value for the validation to treat it as acceptable.  As I discovered, a blank string makes the component go into the invalid validation state ... but there's currently no explanation of this behavior in the docs (that I could find).

Signed-off-by: Jeremy Walker <machineghost@gmail.com>
@mui-bot
Copy link

mui-bot commented May 5, 2024

Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @machineghost! 🙏

Could you clarify the version of the Pickers package that you are using?
Have you recently upgraded?
I suspect that your application is in JS, not TS?
Which date adapter are you using? Isn't your app failing if you bind '' to a value?

This migration item is what also caused an empty string '' to no longer be a valid value, because we stopped parsing the provided prop.

What do you think if we would instead expand the migration section to mention that empty string is longer a valid value as well?
IMHO, validation page does not seem like the most proper place for this, because the problem is not related to validation itself. 🤷 🙈

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants