Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Demonstrate import/no-cycle regression #10062

Closed
wants to merge 1 commit into from

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 17, 2023

A continuation of mui/material-ui#37223 (comment). import/no-cycle is not running in the grid's source. Partially because of the strange package structure for the grid (grid/x-data-grid).

@mui-bot
Copy link

mui-bot commented Aug 17, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-10062--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms -138.9 120.4 120.4 8.16 110.681
Sort 100k rows ms 732.4 1,625.4 1,245.9 1,180.36 286.191
Select 100k rows ms 693.2 853 812.7 795.38 58.35
Deselect 100k rows ms 169.9 247.7 190.2 199.52 28.96

Generated by 🚫 dangerJS against b9fa008

@oliviertassinari oliviertassinari changed the title [core] Fix circular dependency rule [core] Demonstrate import/no-cycle regression Aug 20, 2023
@oliviertassinari
Copy link
Member Author

oliviertassinari commented Aug 20, 2023

Closing, this PR is enough to demonstrate the regression, the test_lint step in Circle CI should have failed.

We have https://www.notion.so/mui-org/Missing-import-no-cycle-in-MUI-X-4671b1264777471f9bf19675d49390fe to keep track of the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants