Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify public for static accessed #3098

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

specify public for static accessed #3098

wants to merge 13 commits into from

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Jan 18, 2024 •
edited

#2917

  • I've read and followed the contributing guide on how to create great pull requests.
  • I've updated the relevant documentation for any new or updated feature.
  • I've linked relevant GitHub issue with "Closes #".
  • I've added a visual demonstration in the form of a screenshot or video.

@JerryWu1234
Copy link
Contributor Author

image

@JerryWu1234 JerryWu1234 marked this pull request as ready for review January 26, 2024 06:09
@zannager zannager requested a review from Janpot January 26, 2024 11:54
@zannager zannager added the create-toolpad-app Issues related to the `create-toolpad-app` CLI tool label Jan 26, 2024
@JerryWu1234
Copy link
Contributor Author

@Janpot help review

@JerryWu1234
Copy link
Contributor Author

@Janpot please help review

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Janpot Janpot Janpot left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool PR: out-of-date The pull request has merge conflicts and can't be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JerryWu1234 @Janpot @zannager