Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to next 13 #1294

Merged
merged 30 commits into from Nov 15, 2022
Merged

Upgrade to next 13 #1294

merged 30 commits into from Nov 15, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Nov 6, 2022

Seems like core wants to move fast on this. So let's try to find the blockers for us to move to Next.js 13 as well.

memory usage (test_static):

before (master):

Screenshot 2022-11-07 at 10 13 54

after:
Screenshot 2022-11-07 at 10 14 01

@render
Copy link

render bot commented Nov 6, 2022

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Nov 6, 2022
@Janpot Janpot changed the title Attempt at upgrading to next 13 Upgrade to next 13 Nov 6, 2022
@mnajdova
Copy link
Member

mnajdova commented Nov 7, 2022

@Janpot should I wait for all issues here to be resolved before merging the PR on the core side?

@Janpot Janpot mentioned this pull request Nov 7, 2022
1 task
@Janpot
Copy link
Member Author

Janpot commented Nov 7, 2022

@mnajdova I'm decoupling the docs update from the toolpad application update in #1297, that should allow you to move forward with mui/material-ui#35001

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 7, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2022
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2022
@Janpot
Copy link
Member Author

Janpot commented Nov 8, 2022

@mnajdova I got this green with only a few stable versions we're waiting on: playwright@1.280 and next@13.0.3. No further blockers as far as I can see.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 8, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Nov 9, 2022
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 14, 2022
{
"groupName": "next",
"matchPackageNames": ["next", "@next/eslint-plugin-next", "eslint-config-next"],
"allowedVersions": "1.2.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄 Should've been 12.2.2, but ok, the effect was the same

@Janpot Janpot marked this pull request as ready for review November 14, 2022 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants