Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Paper] Add elevation boundaries #6817

Merged
merged 1 commit into from
May 8, 2017
Merged

[Paper] Add elevation boundaries #6817

merged 1 commit into from
May 8, 2017

Conversation

oliviertassinari
Copy link
Member

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels May 8, 2017
@oliviertassinari oliviertassinari added component: Paper This is the name of the generic UI component, not the React module! next and removed PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels May 8, 2017
oliviertassinari
oliviertassinari commented May 8, 2017
View reviewed changes
src/Hidden/Hidden.js Outdated
@@ -1,9 +1,61 @@
// @flow
import React, { Element } from 'react';
import HiddenJs from './HiddenJs';
import type { HiddenProps } from './types';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating the definitions as react-docgen isn't smart enough to resolve imports.

rosskevin
rosskevin previously requested changes May 8, 2017
View reviewed changes
Copy link
Member

@rosskevin rosskevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very strongly against duplicating anything at the moment. I have an issue raised and have been thinking about the solution. Duplication is a last resort and I don't think we are there yet. I will raise an issue though so we are tracking it.

@oliviertassinari
Copy link
Member Author

oliviertassinari commented May 8, 2017 •
edited

@rosskevin Right now it's already duplicated between the documentation Hidden.md and the source code (as no longer keep in sync). I would rather have it duplicated in the source code (closer) than in the documentation until we find a solution (the issue has been here for 1 year +).

@rosskevin
Copy link
Member

Please see #6818. We don't need to resort to duplication yet.

@oliviertassinari oliviertassinari dismissed rosskevin’s stale review May 8, 2017 18:37

Removed every changes related to Hidden.

@oliviertassinari oliviertassinari merged commit 15ca5e7 into mui:next May 8, 2017
@oliviertassinari oliviertassinari deleted the next-elevation-boundaries branch May 8, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosskevin rosskevin rosskevin left review comments

Assignees
No one assigned
Labels
component: Paper This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oliviertassinari @rosskevin @muibot