[docs] Improve Paperbase demo #37136
Conversation
…ion-page [docs] Improve Paperbase demo
Netlify deploy previewhttps://deploy-preview-37136--material-ui.netlify.app/ Bundle size report |
…ion-page Improve Paperbase demo - yarn docs:typescript:formatted changes
|
@siriwatknp The "ci/circleci: test_lint" check is failing due to a timeout. Can you please check it? |
|
@gzrae Can you please check why the "ci/circleci: test_lint" check is failing due to timeout |
We tweaked this here! #37223 |
There was a problem hiding this comment.
Thanks for the suggestion but to me, these changes don't make a lot of sense.
- I don't think that we have the resources to add & maintain further pages. One page should be enough.
- Comparing https://mui.com/premium-themes/paperbase/ to
the template is outdated. I think that aiming to better match the brand would bring more value.
| <img | ||
| src="/static/images/buttons/google-signin-dark.png" | ||
| style={{ width: '200px', display: 'block', marginBottom: '10px' }} | ||
| alt="Google Signin button" | ||
| /> | ||
| <img | ||
| src="/static/images/buttons/linkedin-signin-dark.png" | ||
| style={{ width: '200px', display: 'block' }} | ||
| alt="Linkedin Signin button" | ||
| /> |
There was a problem hiding this comment.
These images renders blurry.
There was a problem hiding this comment.
Fixed the blurry images. Please review.
…ion-page [docs] Improve Paperbase demo - Fix blurry images
|
To be quite honest, I don't see a good reason to move forward with these changes, and this PR hasn't been touched in a couple months, so I'm going to go ahead and close it here. @amal-qb, if you'd like to suggest further improvements to this demo, I'd recommend opening an issue first so we can discuss your proposal. Cheers. |
oliviertassinari
added
the
out of scope
Added functionality to the "Authentication" section.