Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eslint-plugin-react to ^7.31.11 #35208

Merged
merged 2 commits into from Dec 9, 2022

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 20, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-react ^7.31.10 -> ^7.31.11 age adoption passing confidence

Release Notes

jsx-eslint/eslint-plugin-react

v7.31.11

Compare Source

Fixed
Changed

Configuration

📅 Schedule: Branch creation - "on sunday before 6:00am" in timezone UTC, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Update of dependencies label Nov 20, 2022
@mui-bot
Copy link

mui-bot commented Nov 20, 2022

Messages
📖 Netlify deploy preview: https://deploy-preview-undefined--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against d4f6154

@Janpot
Copy link
Member

Janpot commented Nov 21, 2022

All but one of these seem to be false positives. I bet it's caused by jsx-eslint/eslint-plugin-react#3459.

Most of these seem to be detected because we add defaultProps or propTypes properties to functions that aren't react components.

@michaldudak michaldudak force-pushed the renovate/eslint-plugin-react-7.x branch from c08a543 to d4f6154 Compare December 8, 2022 12:53
@Janpot
Copy link
Member

Janpot commented Dec 8, 2022

@michaldudak From jsx-eslint/eslint-plugin-react#3495 (comment)

Why would anything that’s not a React component have propTypes?

I'm also kind of wondering about that 🙂

@michaldudak
Copy link
Member

I have no idea what's the use case here. Perhaps @oliviertassinari could shed some light on it?

@renovate
Copy link
Contributor Author

renovate bot commented Dec 8, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.
You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@michaldudak michaldudak merged commit 43a1b3d into master Dec 9, 2022
@michaldudak michaldudak deleted the renovate/eslint-plugin-react-7.x branch December 9, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants