[examples] Fix NextLinkComposedProps type error
#33842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adham Tarek <adhamtarek291@gmail.com>
2 tasks
ZeeshanTamboli
changed the title
NextLinkComposedProps type error
ZeeshanTamboli
added
component: link
ZeeshanTamboli
approved these changes
Aug 8, 2022
There was a problem hiding this comment.
I can confirm that the error does occur in the example with the latest nextjs version 12.2.4. It is similar to what I had done in #32655 by omitting the property.
onTouchStart was added to nextjs Link interface in vercel/next.js#38805.
Looks good to me!
Thanks for the explanation! |
K0rdan
added a commit
to Luos-io/luos
that referenced
this pull request
Aug 29, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Adham Tarek adhamtarek291@gmail.com