Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Document that @emotion/react is not fully supported in the System #31825

Closed
wants to merge 1 commit into from
Closed

[docs] Document that @emotion/react is not fully supported in the System #31825

wants to merge 1 commit into from

Conversation

garronej
Copy link
Contributor

@garronej garronej commented Mar 16, 2022

Hello!

Currently it's not really possible to use@emotion/react to write custom styles for MUI.
More precisely it is possible to use className and the css property but not the classes prop that the MUI component provides.
The reason for that is that the internal styles will always take precedence over the custom styles unless users explicitly increase specificity using !important or && which is not an acceptable solution.
As detailed here there is no way for the user to configure it's project to change this state of things.
I have opened an issue about it some time ago but for reasons that I perfectly understand you decided not to address it.

Considering this, I think it is best, to save users frustration, to let them know that @emotion/react is not really supported.

@mui-bot
Copy link

mui-bot commented Mar 16, 2022

No bundle size changes

Generated by 🚫 dangerJS against ecc36c5

@mnajdova
Copy link
Member

mnajdova commented Mar 16, 2022

Let's see first whether is worth fixing it, before documenting it.

@danilo-leal danilo-leal added the package: system Specific to @mui/system label Mar 16, 2022
@danilo-leal danilo-leal changed the title Document that @emotion/react is not fully supported in style library … [docs] Document that @emotion/react is not fully supported in the System Mar 16, 2022
@danilo-leal danilo-leal added the docs Improvements or additions to the documentation label Mar 16, 2022
@mnajdova mnajdova added the on hold There is a blocker, we need to wait label May 18, 2022
@garronej
Copy link
Contributor Author

garronej commented Aug 8, 2022

Fixed by #33205

@garronej garronej closed this Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation on hold There is a blocker, we need to wait package: system Specific to @mui/system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants