Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Fix side nav scroll position #25619

Merged
merged 2 commits into from Apr 4, 2021
Merged

[docs] Fix side nav scroll position #25619

merged 2 commits into from Apr 4, 2021

Conversation

misaka3
Copy link
Contributor

@misaka3 misaka3 commented Apr 4, 2021 •
edited by oliviertassinari

@mui-pr-bot
Copy link

mui-pr-bot commented Apr 4, 2021 •
edited

No bundle size changes

Generated by 🚫 dangerJS against f08d5e1

@oliviertassinari oliviertassinari changed the title Fix docs drawer when clicking. [docs] Fix docs drawer when clicking Apr 4, 2021
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation bug 🐛 Something doesn't work labels Apr 4, 2021
@oliviertassinari oliviertassinari changed the title [docs] Fix docs drawer when clicking [docs] Fix side nav scroll position Apr 4, 2021
oliviertassinari
oliviertassinari approved these changes Apr 4, 2021
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have pushed an extra commit to isolate the two instances. We could notice a leak on mobile leading to a wrong behavior

@oliviertassinari oliviertassinari merged commit ff2b314 into mui:next Apr 4, 2021
@oliviertassinari
Copy link
Member

It's much better!

@oliviertassinari oliviertassinari mentioned this pull request Apr 8, 2021
Merged
@oliviertassinari oliviertassinari added the scope: docs-infra Specific to the docs-infra product label Dec 31, 2022
@oliviertassinari oliviertassinari mentioned this pull request Mar 10, 2023
Merged
@oliviertassinari oliviertassinari mentioned this pull request Apr 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[docs] When clicking on the left drawer, ancre doesn't stay on the click
3 participants
@misaka3 @mui-pr-bot @oliviertassinari