[docs] Better react-router-dom version comment

[kyarik]

The comment in the linked issue specifies version 5 of react-router-dom and not 6. In fact, there is no version 6 or greater. At this time, the current version of react-router-dom is 5.0.1. So, I updated the comment to say react-router-dom < 5.0.0

• I have followed (at least) the PR section of the contributing guide.

[mui-pr-bot]

No bundle size changes comparing 0c8d847...94732b1

Generated by 🚫 dangerJS against 94732b1

[oliviertassinari]

The version is correct. The usage of forwardRef is still required with react-router v5. The ref prop can't be used, it has to be innerRef.

[oliviertassinari]

I have updated the pull request with a different wording. Does it help? :)

[joshwooding]

The usage of React.forwardRef might no longer be required for react-router-dom v6.

[kyarik]

Yes indeed, after reading more comments in the linked issue, it's evident that react-router-dom v5 doesn't yet support React.forwardRef, but it might support it in v6.

However, I am not sure whether linking to that issue comment is useful. It seems misleading because it appears to say that React.forwardRef will be supported in v5 (and that's why I created this pull request in the first place). Wouldn't it be better to link to this comment instead?

[oliviertassinari]

@kyarik It's a great first pull request on Material-UI 👌🏻. Thank you for working on it!

[kyarik]

@oliviertassinari What a timing! You merged this right when I was about to post the above comment :)

[oliviertassinari]

Interesting, I would hope that linking an open issue is enough.

[kyarik]

I think the link should be either to the entire issue or to this comment because otherwise you say

The usage of React.forwardRef will no longer be required for react-router-dom v6
see remix-run/react-router#6056 (comment)

But that linked comment appears to imply that it is supported in v5, which contradicts the above sentence.

[oliviertassinari]

👍

[kyarik]

Shall I create the pull request?

[oliviertassinari]

Don't worry about it, I batch small changes every now and then (after 1 week or 10 items). It will be updated to only link the issue.