Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Improve lighthouse a11y score in demos #15901

Merged
merged 15 commits into from May 29, 2019

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented May 27, 2019

Audited every component demo with lighthouse a11y audit using https://github.com/eps1lon/mui-scripts-incubator. The following issues were not fixed because they are caused by 3rd party libraries:

There's also an issue with iframes having no title. Will followup in a different PR once #15874 is resolved. Applied in this PR since it directly relates to demos

Fixes can be grouped into the following categories:

@eps1lon eps1lon added docs Improvements or additions to the documentation accessibility a11y labels May 27, 2019
@mui-pr-bot
Copy link

mui-pr-bot commented May 27, 2019

Details of bundle changes.

Comparing: b4de19a...5a2b1ba

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 315,057 315,057 86,304 86,304
@material-ui/core/Paper 0.00% 0.00% 67,921 67,921 20,184 20,184
@material-ui/core/Paper.esm 0.00% 0.00% 61,217 61,217 18,981 18,981
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,345 10,345
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,376 2,376
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,787 5,787
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab 0.00% 0.00% 138,866 138,866 42,660 42,660
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% 0.00% 14,463 14,463 4,181 4,181
Button 0.00% 0.00% 83,901 83,901 25,459 25,459
Modal 0.00% 0.00% 20,343 20,343 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,977 55,977 14,042 14,042
docs.main +0.04% 🔺 +0.05% 🔺 648,696 648,947 204,571 204,664
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 293,979 293,979 83,766 83,766

Generated by 🚫 dangerJS against 5a2b1ba

@eps1lon eps1lon force-pushed the docs/navigation-audit branch 2 times, most recently from ca87f4f to 9312fc3 Compare May 28, 2019 12:10
@eps1lon eps1lon marked this pull request as ready for review May 28, 2019 18:22
@eps1lon eps1lon requested a review from mbrookes May 28, 2019 18:22
Copy link
Member

@mbrookes mbrookes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

@eps1lon
Copy link
Member Author

eps1lon commented May 29, 2019

@mbrookes Could you take a look at aacc9fd ? Add labels/labelledby to every nav element on pages where it appears multiple times i.e. the layout examples don't require a label according to the WAI-ARIA source because on those pages nav only appears once (already indicating it's the primary navigation).

@mbrookes
Copy link
Member

Could you take a look at aacc9fd

LGTM (pending the list semantic HTML PR).

@mui-pr-bot
Copy link

Details of bundle changes.

Comparing: b4de19a...6bdf61d

bundle parsed diff gzip diff prev parsed current parsed prev gzip current gzip
@material-ui/core 0.00% 0.00% 315,057 315,057 86,304 86,304
@material-ui/core/Paper 0.00% 0.00% 67,921 67,921 20,184 20,184
@material-ui/core/Paper.esm 0.00% 0.00% 61,217 61,217 18,981 18,981
@material-ui/core/Popper 0.00% 0.00% 28,740 28,740 10,345 10,345
@material-ui/core/Textarea 0.00% 0.00% 5,513 5,513 2,376 2,376
@material-ui/core/TrapFocus 0.00% 0.00% 3,744 3,744 1,573 1,573
@material-ui/core/styles/createMuiTheme 0.00% 0.00% 15,978 15,978 5,787 5,787
@material-ui/core/useMediaQuery 0.00% 0.00% 2,106 2,106 975 975
@material-ui/lab 0.00% 0.00% 138,866 138,866 42,660 42,660
@material-ui/styles 0.00% 0.00% 51,386 51,386 15,193 15,193
@material-ui/system 0.00% 0.00% 14,463 14,463 4,181 4,181
Button 0.00% 0.00% 83,901 83,901 25,459 25,459
Modal 0.00% 0.00% 20,343 20,343 6,685 6,685
colorManipulator 0.00% 0.00% 3,904 3,904 1,543 1,543
docs.landing 0.00% 0.00% 55,977 55,977 14,042 14,042
docs.main +0.04% 🔺 +0.05% 🔺 648,696 648,947 204,571 204,664
packages/material-ui/build/umd/material-ui.production.min.js 0.00% 0.00% 293,979 293,979 83,766 83,766

Generated by 🚫 dangerJS against 6bdf61d

@eps1lon eps1lon merged commit 831c6cc into mui:master May 29, 2019
@eps1lon eps1lon deleted the docs/navigation-audit branch May 29, 2019 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility a11y docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants