[docs] Link to docs on PRs #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
docs
Netlify deploy preview |
michaldudak
reviewed
May 7, 2024
michaldudak
reviewed
May 7, 2024
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
force-pushed
the
report-link-to-doc
branch
from
d4b4ef1
to
d9b6aa7
Compare
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
force-pushed
the
report-link-to-doc
branch
from
d84a067
to
a7a931b
Compare
oliviertassinari
force-pushed
the
report-link-to-doc
branch
from
a7a931b
to
0dc2ca4
Compare
Co-authored-by: Michał Dudak <michal.dudak@gmail.com> Signed-off-by: Olivier Tassinari <olivier.tassinari@gmail.com>
oliviertassinari
added a commit
to mui/pigment-css
that referenced
this pull request
May 9, 2024
oliviertassinari
added a commit
to mui/material-ui
that referenced
this pull request
May 9, 2024
michaldudak
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #393, I have noticed that we are missing the easy access link to the docs.
I faced a bit working on this danger/danger-js#1180. I removed the
formatFileToLink()import; The logic feels broken anyway, at least, in my view. In the end, this PR is close to what MUI X's uses. I think it will be great to normalize the markdown output at one point. I don't think it's great right now, but it's a larger scope. I'm going with the bare minimum possible change, to still place us a step forward.I think we will need to aggregate bundle size reports too in the future: #201.