fix: read fore/background colors on first access #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
color-cache
branch
from
6baed07
to
9de16e1
Compare
Caching the colors in OutputOption makes the order of options important. For example, if you're using WithUnsafe _after_ WithColorCache, the colors wouldn't respect the `unsafe` option since the colors get cached _during_ the execution of WithColorCache option. Another example, is the use of a custom environ using the WithEnvironment option. If WithEnvironment comes _after_ WithColorCache, reading the terminal colors won't respect the values in the environment. Instead, don't read the colors in WithColorCache and make the user opt-in if they want to cache the colors right after creating a new output using ForegroundColor and BackgroundColor. ```go // To cache the colors after creating an output output := NewOutput(os.Stderr) _ = output.ForegroundColor() _ = output.BackgroundColor() ```
aymanbagabas
force-pushed
the
color-cache
branch
from
9de16e1
to
fbe6f55
Compare
caarlos0
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching the colors in OutputOption makes the order of options important. For example, if you're using WithUnsafe after WithColorCache, the colors wouldn't respect the
unsafeoption since the colors get cached during the execution of WithColorCache option.Another example, is the use of a custom environ using the WithEnvironment option. If WithEnvironment comes after WithColorCache, reading the terminal colors won't respect the values in the environment.
Instead, don't read the colors in WithColorCache and make the user opt-in if they want to cache the colors right after creating a new output using ForegroundColor and BackgroundColor.