fix!: output race condition #146
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aymanbagabas
force-pushed
the
race-fix
branch
2 times, most recently
from
de1ed94
to
3cf3563
Compare
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jul 28, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the color profile causing a race condition. Needs: muesli/termenv#146
caarlos0
approved these changes
Jul 28, 2023
aymanbagabas
force-pushed
the
race-fix
branch
2 times, most recently
from
c0b676e
to
3c898b2
Compare
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jul 28, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the color profile causing a race condition. Needs: muesli/termenv#146
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jul 28, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jul 28, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Jul 28, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
Use a mutex to guard setting/getting the color profile and fg/bg colors. Use `SetColorProfile` to change the output color profile. Use pointer receiver since we have a lock in the struct. Fixes: charmbracelet/lipgloss#210 Fixes: #145
aymanbagabas
added a commit
to charmbracelet/lipgloss
that referenced
this pull request
Aug 1, 2023
Guard accessing the underlying Termenv output behind a mutex. Multiple goroutines can set/get the dark background color causing a race condition. Needs: muesli/termenv#146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING!
Use a mutex to guard setting/getting the color profile and fg/bg colors.
Use
SetColorProfileto change the output color profile.Use pointer receiver since we have a lock in the struct.
Fixes: charmbracelet/lipgloss#210
Fixes: #145
Fixes: charmbracelet/log#67