Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use EnvColorProfile #74

Merged
merged 1 commit into from Oct 18, 2020
Merged

Use EnvColorProfile #74

merged 1 commit into from Oct 18, 2020

Conversation

xzfc
Copy link
Contributor

@xzfc xzfc commented Oct 17, 2020

This change provides a way to enable colors (#11) via environment variable CLICOLOR_FORCE=1, as well as respects other env vars (described here).

@xzfc
Copy link
Contributor Author

xzfc commented Oct 17, 2020 •
edited

Currently, it is ANSI 8-color palette only.

I think a sane way to enable 24bit-color is to let termenv.EnvColorProfile() consider TERM and COLORTERM variables. It currently doesn't if the output isn't a tty.

@muesli muesli merged commit ef3c542 into muesli:master Oct 18, 2020
@muesli
Copy link
Owner

muesli commented Oct 18, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xzfc @muesli